From: | opolofdez <opolofdez(at)gmail(dot)com> |
---|---|
To: | rjuju123(at)gmail(dot)com, michael(at)paquier(dot)xyz |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Douglas Doole <dougdoole(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Collation versioning |
Date: | 2020-03-17 14:23:47 |
Message-ID: | shg1dtku9ieudv3ob7u0t04b.1584455027802@email.android.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
<div dir="ltr">njhjo<br>
</div><div dir="ltr"><br>
</div><div dir="ltr"><br>
</div><div dir="ltr"><br>
</div><div class="wps_signature">Enviado desde mi Redmi 4A</div><div class="wps_quotion">El Julien Rouhaud <rjuju123(at)gmail(dot)com>, 16 mar. 2020 3:05 p. m. escribió:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p></p><p dir="ltr">On Mon, Mar 16, 2020 at 04:57:38PM +0900, Michael Paquier wrote:
<br>
> On Thu, Mar 12, 2020 at 03:00:26PM +0100, Julien Rouhaud wrote:
<br>
> > And v15 due to conflict with b08dee24a5 (Add pg_dump support for ALTER obj
<br>
> > DEPENDS ON EXTENSION).
<br>
>
<br>
> I have looked at patches 0001~0003 in the set for now.
<br>
<br>
<br>
Thanks!
<br>
<br>
<br>
> In patch 0002, you have the following addition:
<br>
> @@ -103,9 +103,10 @@ ORDER BY 1, 2;
<br>
> pg_class | relacl | aclitem[]
<br>
> pg_class | reloptions | text[]
<br>
> pg_class | relpartbound | pg_node_tree
<br>
> + pg_depend | refobjversion | text
<br>
> This comes from a regression test doing a sanity check to look for
<br>
> catalogs which have a toastable column but no toast tables. As an
<br>
> exception, it should be documented in the test's comment. Actually,
<br>
> does it need to be an exception? This does not depend on
<br>
> relation-level facilities so there should be no risk of recursive
<br>
> dependencies, though I have not looked in details at this part.
<br>
<br>
<br>
I totally missed that, and I agree that there's no need for an exception, so
<br>
fixed.
<br>
<br>
<br>
> + <para>
<br>
> + The only current use of <structfield>refobjversion</structfield> is to
<br>
> + record dependencies between indexes and collation versions.
<br>
> + </para>
<br>
> [...]
<br>
> + <row>
<br>
> + <entry><structfield>refobjversion</structfield></entry>
<br>
> + <entry><type>text</type></entry>
<br>
> + <entry></entry>
<br>
> + <entry>
<br>
> + An optional version for the referenced object; see text
<br>
> + </entry>
<br>
> + </row>
<br>
> Couldn't you merge both paragraphs here?
<br>
<br>
<br>
Done.
<br>
<br>
<br>
> Regarding patch 0003, it would be nice to include some tests
<br>
> independent on the rest and making use of the new functions. These
<br>
> normally go in regproc.sql. For example with a collation that needs
<br>
> double quotes as this is not obvious:
<br>
> =# select regcollation('"POSIX"');
<br>
> regcollation
<br>
> --------------
<br>
> "POSIX"
<br>
> (1 row)
<br>
>
<br>
> On top of that, this needs tests with to_regcollation() and tests with
<br>
> schema-qualified collations.
<br>
<br>
<br>
Done too, using the same collation name, for both with and without schema
<br>
qualification.
<br>
<br>
<br>
> Documentation for to_regcollation() is missing. And it looks that
<br>
> many parts of the documentation are missing an update. One example in
<br>
> datatype.sgml:
<br>
> Type <type>oid</type> represents an object identifier. There are also
<br>
> several alias types for <type>oid</type>: <type>regproc</type>,
<br>
> <type>regprocedure</type>, <type>regoper</type>, <type>regoperator</type>,
<br>
> <type>regclass</type>, <type>regtype</type>, <type>regrole</type>,
<br>
> <type>regnamespace</type>, <type>regconfig</type>, and
<br>
> <type>regdictionary</type>. <xref linkend="datatype-oid-table"/> shows an
<br>
> overview.
<br>
> At quick glance, there are more sections in need of a refresh..
<br>
<br>
<br>
Indeed. I found missing reference in datatype.sgml; func.sgml and
<br>
pgupgrade.sgml.
<br>
<br>
v16 attached.
<br>
</p>
</blockquote></div>
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/html | 4.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2020-03-17 15:24:09 | Re: Berserk Autovacuum (let's save next Mandrill) |
Previous Message | Chapman Flack | 2020-03-17 14:17:37 | Re: How to install https://github.com/sraoss/pgsql-ivm on postgress |