| From: | Evgeny Voropaev <evgeny(dot)voropaev(at)tantorlabs(dot)com> |
|---|---|
| To: | aleksander(at)timescale(dot)com, pgsql-hackers(at)postgresql(dot)org, alvherre(at)alvh(dot)no-ip(dot)org |
| Subject: | Re: Elimination of the repetitive code at the SLRU bootstrap functions. |
| Date: | 2025-02-14 06:54:06 |
| Message-ID: | fd98bc50-7488-414b-9e98-cb786132e114@tantorlabs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Aleksander!
Hello Álvaro!
Thank you for your attention to the patch.
> Since BootStrapSlruPage() is the only caller of ZeroPage() it seems to
> me that it merely wastes space in SlruCtlData. On top of that I'm not
> 100% sure if all the supported platforms have C99 compilers with
> designated initializers support.
> Wouldn't it be simpler to pass the callback straight to
> BootStrapSlruPage()?
I agree with your proposals. Moreover, similar solution is also implemented and exploited at
Tantor's versions of the xid64 patch (https://www.postgresql.org/message-id/5ca56aed-dc69-4c3e-968f-a822ae0937b5%40gmail.com)
The corrected patch version implementing these proposals is attached.
Best regards,
Evgeny Voropaev,
Tantor Labs LLC.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Elimination-of-the-repetitive-code-at-the-SLRU-bo.patch | text/x-patch | 9.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-02-14 07:18:42 | Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding |
| Previous Message | Michael Paquier | 2025-02-14 06:24:22 | Re: Move wal_buffers_full to WalUsage (and report it in pgss/explain) |