From: | <pokurev(at)pm(dot)nttdata(dot)co(dot)jp> |
---|---|
To: | <pgsql-hackers(at)postgresql(dot)org> |
Cc: | <bannos(at)nttdata(dot)co(dot)jp> |
Subject: | Re: [PROPOSAL] VACUUM Progress Checker. |
Date: | 2016-02-05 08:15:58 |
Message-ID: | f9577bef0c4e4f1892b38abeac547894@MP-MSGSS-MBX007.msg.nttdata.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello,
Please find attached updated patch.
>The point of having pgstat_report_progress_update_counter() is so that
>you can efficiently update a single counter without having to update
>everything, when only one counter has changed. But here you are
>calling this function a whole bunch of times in a row, which
>completely misses the point - if you are updating all the counters,
>it's more efficient to use an interface that does them all at once
>instead of one at a time.
The pgstat_report_progress_update_counter() is called at appropriate places in the attached patch.
>So I've spent a fair amount of time debugging really-long-running
>VACUUM processes with customers, and generally what I really want to
>know is:
>>>> What block number are we at? <<<
Agreed. The attached patch reported current block number.
Regards,
Vinayak
Attachment | Content-Type | Size |
---|---|---|
Vacuum_progress_checker_v11.patch | application/octet-stream | 22.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2016-02-05 08:17:47 | Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs) |
Previous Message | Kyotaro HORIGUCHI | 2016-02-05 08:09:01 | IF (NOT) EXISTS in psql-completion |