Re: Enable data checksums by default

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enable data checksums by default
Date: 2024-08-15 06:38:38
Message-ID: ec7b2d70-0864-4d49-80e5-a0f3f875426b@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08.08.24 19:42, Robert Haas wrote:
>> I'm thinking pg_upgrade could have a mode where it adds the
>> checksum during the upgrade as it copies the files (essentially a subset
>> of pg_checksums). I think that would be useful for that middle tier of
>> users who just want a good default experience.
> That would be very nice.

Here is a demo patch for that. It turned out to be quite simple.

I wrote above about a separate mode for that (like
--copy-and-make-adjustments), but it was just as easy to stick it into
the existing --copy mode.

It would be useful to check what the performance overhead of this is
versus a copy that does not have to make adjustments. I expect it's
very little.

A drawback is that as written this does not work on Windows, because
Windows uses a different code path in copyFile(). I don't know the
reasons for that. But it would need to be figured out.

Attachment Content-Type Size
v0-0001-pg_upgrade-support-for-upgrading-to-checksums-ena.patch text/plain 4.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ayush Vatsa 2024-08-15 06:52:34 Re: Proposal to have INCLUDE/EXCLUDE options for altering option values
Previous Message Peter Smith 2024-08-15 06:27:01 Re: Logical Replication of sequences