Re: CREATE TABLE ( .. STORAGE ..)

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: wenjing zeng <wjzeng2012(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: CREATE TABLE ( .. STORAGE ..)
Date: 2022-02-02 10:13:29
Message-ID: ea723b92-d87a-aeef-3467-56453a36921d@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

> Are they both set to name or ColId? Although they are the same.
>

Thank you, fixed, that was just an oversight.

> 2 For ColumnDef new member storage_name, did you miss the function _copyColumnDef() _equalColumnDef()?

Thank you, fixed

>
>
> Regards
> Wenjing
>
>
>> 2021年12月27日 15:51,Teodor Sigaev <teodor(at)sigaev(dot)ru> 写道:
>>
>> Hi!
>>
>> Working on pluggable toaster (mostly, for JSONB improvements, see links below) I had found that STORAGE attribute on column is impossible to set in CREATE TABLE command but COMPRESS option is possible. It looks unreasonable. Suggested patch implements this possibility.
>>
>> [1] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfnyc-2021.pdf
>> [2] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgvision-2021.pdf
>> [3] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfonline-2021.pdf
>> [4] http://www.sai.msu.su/~megera/postgres/talks/bytea-pgconfonline-2021.pdf
>>
>> PS I will propose pluggable toaster patch a bit later
>> --
>> Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
>> WWW: http://www.sigaev.ru/<create_table_storage-v1.patch.gz>
>

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

Attachment Content-Type Size
create_table_storage-v2.patch.gz application/gzip 3.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-02-02 11:49:26 Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work
Previous Message Ajin Cherian 2022-02-02 09:16:23 Re: row filtering for logical replication