| From: | "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: "unexpected duplicate for tablespace" problem in logical replication |
| Date: | 2022-04-11 10:24:26 |
| Message-ID: | dff776f7-fd73-6b14-a6c0-fba8c3858735@fujitsu.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi, Osumi-san, Thank you for your comment.
On 4/11/22 15:40, Osumi, Takamichi/大墨 昂道 wrote:
> (1) Name of isRelNodeCollision
changed.
> (2) Remove curly brackets for one sentence
changed.
> (3) variables of isRelNodeCollision
changed.
> (4) Having Assert in isRelNodeCollision
added.
> (5) argument name of isRelNodeCollision
changed.
BTW, I also change the parameter from null to SnapshotAny
scandesc = systable_beginscan(pg_class,
ClassTblspcRelfilenodeIndexId,
- true, NULL, 2, skey);
+ true, SnapshotAny, 2, skey);
I'm not sure, but I think SnapshotAny is more suitable after reading the
source(comment) in function GetNewOidWithIndex().
Please see the attachment
Regards,
Shenhao Wang
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Check-the-duplicated-relfilenode-when-create-tabl.patch | text/x-patch | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-04-11 15:55:19 | Re: BUG #17462: Invalid memory access in heapam_tuple_lock |
| Previous Message | PG Bug reporting form | 2022-04-11 07:46:41 | BUG #17462: Invalid memory access in heapam_tuple_lock |