| From: | Andrei Zubkov <zubkov(at)moonset(dot)ru> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Greg Stark <stark(at)mit(dot)edu>, "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements |
| Date: | 2022-04-02 12:02:22 |
| Message-ID: | df10fe61d3403f97691ef52e76c025a90f0bd18e.camel@moonset.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 2022-04-02 at 14:11 +0300, Andrei Zubkov wrote:
> On Sat, 2022-04-02 at 18:56 +0800, Julien Rouhaud wrote:
> > Maybe a macro would be better here? I don't know if that's
> > generally
> > ok or
> > just old and not-that-great code, but there are other places
> > relying
> > on macros
> > when a plain function call isn't that convenient (like here
> > returning
> > 0 or 1 as
> > a hack for incrementing num_remove), for instance in hba.c.
>
> Yes, it is not very convenient and not looks pretty, so I'll try a
> macro here soon.
Implemented SINGLE_ENTRY_RESET as a macro.
v10 attached
--
regards, Andrei
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-pg_stat_statements-Track-statement-entry-timestamp.patch | text/x-patch | 62.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-04-02 12:38:26 | Re: [PATCH] Add extra statistics to explain for Nested Loop |
| Previous Message | Tomas Vondra | 2022-04-02 11:58:43 | Re: logical decoding and replication of sequences |