| From: | "Daniel Verite" <daniel(at)manitou-mail(dot)org> |
|---|---|
| To: | "Daniel Verite" <daniel(at)manitou-mail(dot)org> |
| Cc: | "Stephen Frost" <sfrost(at)snowman(dot)net>,"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Rahila Syed" <rahilasyed90(at)gmail(dot)com>,"Ashutosh Bapat" <ashutosh(dot)bapat(at)enterprisedb(dot)com>,"pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improvements in psql hooks for variables |
| Date: | 2016-11-23 12:17:31 |
| Message-ID: | de7ebdcd-6f4b-47b9-9612-71dffb8355a6@mm |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> So I went through the psql commands which don't fail on parse errors
> for booleans
> [...]
Here's a v5 patch implementing the suggestions mentioned upthread:
all meta-commands calling ParseVariableBool() now fail
when the boolean argument can't be parsed successfully.
Also includes a minor change to SetVariableAssignHook() that now
returns the result of the hook it calls after installing it.
It doesn't make any difference in psql behavior since callers
of SetVariableAssignHook() ignore its return value, but it's
more consistent with SetVariable().
Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite
| Attachment | Content-Type | Size |
|---|---|---|
| psql-var-hooks-v5.patch | text/plain | 15.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2016-11-23 12:58:22 | [bugfix] commit timestamps ERROR on lookup of FrozenTransactionId |
| Previous Message | Thomas Munro | 2016-11-23 12:12:41 | Re: Creating a DSA area to provide work space for parallel execution |