From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net> |
Cc: | Sergei Kornilov <sk(at)zsrv(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: could recovery_target_timeline=latest be the default in standby mode? |
Date: | 2018-12-28 11:08:43 |
Message-ID: | dbebe59f-fc22-9b4c-a6f8-4ed5816a70ea@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 28/12/2018 00:15, Michael Paquier wrote:
> Yes, I was also thinking something among those lines, and the patch is
> a bit confusing by linking standby mode with latest timeline. It
> seems to me that switching the default value to "latest" at GUC level
> would be the way to go, instead of picking up the TLI from the control
> file. Introducing a new value which maps to the current empty value
> may be useful as well, like "control_file"?
OK, here are patches for this approach:
1. Add value 'current' for recovery_target_timeline
2. Change default of recovery_target_timeline to 'latest'
The first is really a fixup of the recovery.conf-removal patch. In
<=PG11, you could not explicitly select the current timeline; it was
only available if you don't mention recovery_target_timeline at all.
The original patch contained a setting 'controlfile', similar to your
suggestion, but that sounds a bit low-level implementation detail to me.
I like the suggestion 'current'.
The second then just changes the GUC default, without any special
treatment for standby mode.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Add-value-current-for-recovery_target_timeline.patch | text/plain | 3.3 KB |
v2-0002-Change-default-of-recovery_target_timeline-to-lat.patch | text/plain | 9.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2018-12-28 11:46:13 | Prepare Transaction support for ON COMMIT DROP temporary tables |
Previous Message | Fabien COELHO | 2018-12-28 11:07:30 | Re: random() (was Re: New GUC to sample log queries) |