| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add CREATE DATABASE LOCALE option |
| Date: | 2019-07-22 18:36:39 |
| Message-ID: | d58f96ca-7f7a-7110-c560-1347a85407be@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-07-13 19:20, Fabien COELHO wrote:
> The second error message about conflicting option could more explicit than
> a terse "conflicting or redundant options"? The user may expect later
> options to superseedes earlier options, for instance.
done
> About the pg_dump code, I'm wondering whether it is worth generating
> LOCALE as it breaks backward compatibility (eg dumping a new db to load it
> into a older version).
We don't really care about backward compatibility here. Moving forward,
with ICU and such, we don't want to have to drag around old syntax forever.
> If it is to be generated, I'd do merge the two conditions instead of
> nesting.
>
> if (strlen(collate) > 0 && strcmp(collate, ctype) == 0)
> // generate LOCALE
done
How about this patch?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-CREATE-DATABASE-LOCALE-option.patch | text/plain | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-07-22 19:02:24 | Re: Broken defenses against dropping a partitioning column |
| Previous Message | Tom Lane | 2019-07-22 18:35:32 | Re: using explicit_bzero |