From: | chenhj <chjischj(at)163(dot)com> |
---|---|
To: | "Alexander Korotkov" <a(dot)korotkov(at)postgrespro(dot)ru> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH]make pg_rewind to not copy useless WAL files |
Date: | 2017-09-28 19:52:43 |
Message-ID: | d4495b3.674.15eca0c6329.Coremail.chjischj@163.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2017-09-29 00:43:18,"Alexander Korotkov" <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
On Thu, Sep 28, 2017 at 6:44 PM, chenhj <chjischj(at)163(dot)com> wrote:
On 2017-09-28 01:29:29,"Alexander Korotkov" <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
It appears that your patch conflicts with fc49e24f. Please, rebase it.
Yes, i had rebased it, Please check the new patch.
Good, now it applies cleanly.
else if (strncmp(path, XLOGDIR"/", strlen(XLOGDIR"/")) == 0 &&
IsXLogFileName(path + strlen(XLOGDIR"/")) &&
(strcmp(path + strlen(XLOGDIR"/") + 8, divergence_wal_filename + 8) < 0 ||
strcmp(path + strlen(XLOGDIR"/") + 8, last_source_wal_filename + 8) > 0))
According to our conding style, you should leave a space betwen XLOGDIF and "/".
Also, you do a trick by comparison xlog segment numbers using strcmp(). It's nice, but I would prefer seeing XLogFromFileName() here. It would improve code readability and be less error prone during further modifications.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Thanks for advice!
I had modified it.
-----
Best Regards,
Chen Huajun
Attachment | Content-Type | Size |
---|---|---|
pg_rewind_wal_copy_reduce_v5.patch | application/octet-stream | 9.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2017-09-28 20:07:09 | Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple |
Previous Message | Jesper Pedersen | 2017-09-28 19:40:35 | initdb w/ restart |