Re: Amcheck verification of GiST and GIN

From: Tomas Vondra <tomas(at)vondra(dot)me>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Amcheck verification of GiST and GIN
Date: 2025-03-28 16:26:34
Message-ID: d2ee3c1e-f51b-46bf-8307-be545e3b85d2@vondra.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here's a polished version of the patches. If you have any
comments/objections, please speak now. I don't plan to push 0006 (the
stress test), of course.

Changes I did:

1) update / write proper commit messages, hopefully explaining the
purpose of each patch well enough

2) update the lists of reviewers/authors (would appreciate someone
checking - it's hard to keep track for a thread that runs for years, and
it may not be quite clear what qualifies as a review)

3) squash the fix patch into the right patch, moved the README fix to be
the first patch (doesn't really matter)

4) minor cleanups in the main patches (0002 and 0003), mostly adding the
structs to typedefs.list and tweaking a couple comments

5) I've adjusted names of the memory contexts, because having both with
"amcheck context" seemed confusing, especially as it's in caller-callee
functions. So now it's

- amcheck consistency check context
- posting tree check context

regards

--
Tomas Vondra

Attachment Content-Type Size
v20250328-0001-Fix-grammar-in-GIN-README.patch text/x-patch 1.4 KB
v20250328-0002-amcheck-Move-common-routines-into-a-separa.patch text/x-patch 22.4 KB
v20250328-0003-amcheck-Add-gin_index_check-to-verify-GIN-.patch text/x-patch 35.7 KB
v20250328-0004-amcheck-Add-a-test-with-GIN-index-on-JSONB.patch text/x-patch 2.4 KB
v20250328-0005-amcheck-Add-a-GIN-index-to-the-CREATE-INDE.patch text/x-patch 6.3 KB
v20250328-0006-Stress-test-verify_gin-using-pgbench.patch text/x-patch 9.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-03-28 16:32:47 Re: On non-Windows, hard depend on uselocale(3)
Previous Message Masahiko Sawada 2025-03-28 16:14:53 Re: On non-Windows, hard depend on uselocale(3)