Add support for automatically updating Unicode derived files

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Add support for automatically updating Unicode derived files
Date: 2019-10-29 10:06:05
Message-ID: c8d05f42-443e-6c23-819b-05b31759a37c@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Continuing the discussion from [0] and [1], here is a patch that
automates the process of updating Unicode derived files. Summary:

- Edit UNICODE_VERSION and/or CLDR_VERSION in src/Makefile.global.in
- Run make update-unicode
- Commit

I have added that to the release checklist in RELEASE_NOTES.

This also includes the script used in [0] that was not committed at that
time. Other than that, this just refactors existing build code.

Open questions that are currently not handled consistently:

- Should the downloaded files be listed in .gitignore?
- Should the downloaded files be cleaned by make clean (or distclean or
maintainer-clean or none)?
- Should the generated files be excluded from pgindent? Currently, the
generated files will not pass pgindent unchanged, so that could cause
annoying whitespace battles when these files are updated and re-indented
around release time.

[0]:
https://www.postgresql.org/message-id/flat/bbb19114-af1e-513b-08a9-61272794bd5c%402ndquadrant.com
[1]:
https://www.postgresql.org/message-id/flat/77f69366-ca31-6437-079f-47fce69bae1b%402ndquadrant.com

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Add-support-for-automatically-updating-Unicode-deriv.patch text/plain 17.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2019-10-29 10:29:32 Re: [HACKERS] advanced partition matching algorithm for partition-wise join
Previous Message Dilip Kumar 2019-10-29 09:41:44 Re: [HACKERS] Block level parallel vacuum