Re: Don't try fetching future segment of a TLI.

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: psuderevsky(at)gmail(dot)com, david(at)pgmasters(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Don't try fetching future segment of a TLI.
Date: 2020-04-07 03:22:20
Message-ID: c722ac2a-e923-6179-8fc8-30dbca48f018@oss.nttdata.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2020/04/07 10:29, Kyotaro Horiguchi wrote:
> Thank you for picking this up.
>
> At Tue, 7 Apr 2020 02:43:02 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
>> On 2020/03/19 22:22, Pavel Suderevsky wrote:
>>> Hi,
>>> I've tested patch provided by Kyotaro and do confirm it fixes the
>>> issue.
>>
>> The patch looks good to me. Attached is the updated version of the
>> patch.
>> I updated only comments.
>
> + * The logfile segment that doesn't belong to the timeline is
> + * older or newer than the segment that the timeline started or
> + * eneded at, respectively. It's sufficient to check only the
>
> s/eneded/ended/ ?

Yes! Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
v3-0001-Don-t-try-fetching-out-of-timeline-segments.patch text/plain 1.5 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-04-07 07:48:01 Re: Don't try fetching future segment of a TLI.
Previous Message Fujii Masao 2020-04-07 03:15:00 Re: Don't try fetching future segment of a TLI.

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-04-07 03:32:56 Re: Autovacuum on partitioned table (autoanalyze)
Previous Message Amit Langote 2020-04-07 03:17:07 Re: d25ea01275 and partitionwise join