Re: cast result of copyObject()

> The problem this patch would address is that currently you can write
>
> SomeNode *x = ...;
>
> ...
>
>
> OtherNode *y = copyObject(x);
>
> and there is no notice about that potential mistake.
>
> This patch makes that an error.
>
> If you are sure about what you are doing, you can add a cast. But
> casting the result of copyObject() should be limited to a few specific
> cases where the result is assigned to a generic Node * or something like
> that.

Updated patch, which I will register in the commit fest for some wider
portability testing (Windows!).

(changed subject copyNode -> copyObject (was excited about castNode at
the time))

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services