From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Japin Li <japinli(at)hotmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Improve readability by using designated initializers when possible |
Date: | 2024-03-13 13:24:32 |
Message-ID: | bdf072b2-2ca1-46ea-a261-fd6ebae83ea4@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 08.03.24 06:50, Michael Paquier wrote:
> On Mon, Mar 04, 2024 at 09:29:03AM +0800, jian he wrote:
>> On Fri, Mar 1, 2024 at 5:26 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>> Oops, there was a second commit in my branch that I neglected to send
>>> in. Here is my complete patch set.
>
> Thanks for the new patch set. The gains are neat, giving nice
> numbers:
> 7 files changed, 200 insertions(+), 644 deletions(-)
>
> + default:
> + DropObjectById(object);
> + break;
>
> Hmm. I am not sure that this is a good idea. Wouldn't it be safer to
> use as default path something that generates an ERROR so as this code
> path would complain immediately when adding a new catalog?
fixed in new patch
> In getObjectDescription() and getObjectTypeDescription() this was a
> safeguard, but we don't have that anymore. So it seems to me that
> this should be replaced with a default with elog(ERROR)?
fixed
>> there is a `OCLASS` at the end of getObjectIdentityParts.
>
> Nice catch. A comment is not updated.
>
>> There is a `ObjectClass` in typedefs.list
>
> This is usually taken care of by committers or updated automatically.
both fixed
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Remove-ObjectClass.patch | text/plain | 51.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Laurenz Albe | 2024-03-13 13:27:27 | Re: Disabling Heap-Only Tuples |
Previous Message | Shlok Kyal | 2024-03-13 13:09:21 | Re: speed up a logical replica setup |