From: | Anton Kirilov <antonvkirilov(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add PQsendSyncMessage() to libpq |
Date: | 2023-11-12 13:37:16 |
Message-ID: | b878b8d2-8481-4fde-a374-5ccb9168d4e4@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello,
Thanks for the feedback!
On 07/11/2023 09:23, Jelte Fennema-Nio wrote:
> But I think it's looking at the situation from the wrong direction.
[...] we should look at it as an addition to our current list of PQsend
functions for a new packet type. And none of those PQsend functions ever
needed a flag. Which makes sense, because they are the lowest level
building blocks that make sense from a user perspective: They send a
message type over the socket and don't do anything else.
Yes, I think that this is quite close to my thinking when I created the
original version of the patch. Also, the protocol specification states
that the Sync message lacks parameters.
Since there haven't been any comments from the other people who have
chimed in on this e-mail thread, I will assume that there is consensus
(we are doing a U-turn with the implementation approach after all), so
here is the updated version of the patch.
Best wishes,
Anton Kirilov
Attachment | Content-Type | Size |
---|---|---|
v5-0001-Add-PQsendPipelineSync-to-libpq.patch | text/x-patch | 9.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2023-11-12 14:09:27 | Re: pg_basebackup check vs Windows file path limits |
Previous Message | Pavel Stehule | 2023-11-12 13:17:03 | Re: proposal: possibility to read dumped table's name from file |