From 50ca33b96bf6017f04863486763e2e3250c5cc0a Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Sat, 18 Aug 2018 08:13:49 -0700 Subject: [PATCH 2/4] XXX: Copy slot in nodeMaterial.c This is needed because otherwise upper layers can't make correct assumptions about the type of slot handed up. Author: Reviewed-By: Discussion: https://postgr.es/m/ Backpatch: --- src/backend/executor/nodeMaterial.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/backend/executor/nodeMaterial.c b/src/backend/executor/nodeMaterial.c index 66c4ef6ca90..fc36aedfa26 100644 --- a/src/backend/executor/nodeMaterial.c +++ b/src/backend/executor/nodeMaterial.c @@ -146,10 +146,8 @@ ExecMaterial(PlanState *pstate) if (tuplestorestate) tuplestore_puttupleslot(tuplestorestate, outerslot); - /* - * We can just return the subplan's returned tuple, without copying. - */ - return outerslot; + ExecCopySlot(slot, outerslot); + return slot; } /* -- 2.18.0.rc2.dirty