*** a/src/backend/commands/indexcmds.c --- b/src/backend/commands/indexcmds.c *************** *** 1768,1774 **** ReindexTable(RangeVar *relation) heapOid = RangeVarGetRelidExtended(relation, ShareLock, false, false, RangeVarCallbackOwnsTable, NULL); ! if (!reindex_relation(heapOid, REINDEX_REL_PROCESS_TOAST)) ereport(NOTICE, (errmsg("table \"%s\" has no indexes", relation->relname))); --- 1768,1776 ---- heapOid = RangeVarGetRelidExtended(relation, ShareLock, false, false, RangeVarCallbackOwnsTable, NULL); ! if (!reindex_relation(heapOid, ! REINDEX_REL_PROCESS_TOAST | ! REINDEX_REL_CHECK_CONSTRAINTS)) ereport(NOTICE, (errmsg("table \"%s\" has no indexes", relation->relname))); *************** *** 1884,1890 **** ReindexDatabase(const char *databaseName, bool do_system, bool do_user) StartTransactionCommand(); /* functions in indexes may want a snapshot set */ PushActiveSnapshot(GetTransactionSnapshot()); ! if (reindex_relation(relid, REINDEX_REL_PROCESS_TOAST)) ereport(NOTICE, (errmsg("table \"%s.%s\" was reindexed", get_namespace_name(get_rel_namespace(relid)), --- 1886,1894 ---- StartTransactionCommand(); /* functions in indexes may want a snapshot set */ PushActiveSnapshot(GetTransactionSnapshot()); ! if (reindex_relation(relid, ! REINDEX_REL_PROCESS_TOAST | ! REINDEX_REL_CHECK_CONSTRAINTS)) ereport(NOTICE, (errmsg("table \"%s.%s\" was reindexed", get_namespace_name(get_rel_namespace(relid)), *** a/src/test/regress/expected/create_index.out --- b/src/test/regress/expected/create_index.out *************** *** 2298,2306 **** COMMIT; BEGIN; CREATE INDEX std_index on concur_heap(f2); COMMIT; ! -- check to make sure that the failed indexes were cleaned up properly and the ! -- successful indexes are created properly. Notably that they do NOT have the ! -- "invalid" flag set. \d concur_heap Table "public.concur_heap" Column | Type | Modifiers --- 2298,2310 ---- BEGIN; CREATE INDEX std_index on concur_heap(f2); COMMIT; ! -- Failed builds are left invalid by VACUUM FULL, fixed by REINDEX ! VACUUM FULL concur_heap; ! REINDEX TABLE concur_heap; ! ERROR: could not create unique index "concur_index3" ! DETAIL: Key (f2)=(b) is duplicated. ! DELETE FROM concur_heap WHERE f1 = 'b'; ! VACUUM FULL concur_heap; \d concur_heap Table "public.concur_heap" Column | Type | Modifiers *************** *** 2316,2321 **** Indexes: --- 2320,2341 ---- "concur_index5" btree (f2) WHERE f1 = 'x'::text "std_index" btree (f2) + REINDEX TABLE concur_heap; + \d concur_heap + Table "public.concur_heap" + Column | Type | Modifiers + --------+------+----------- + f1 | text | + f2 | text | + Indexes: + "concur_index2" UNIQUE, btree (f1) + "concur_index3" UNIQUE, btree (f2) + "concur_heap_expr_idx" btree ((f2 || f1)) + "concur_index1" btree (f2, f1) + "concur_index4" btree (f2) WHERE f1 = 'a'::text + "concur_index5" btree (f2) WHERE f1 = 'x'::text + "std_index" btree (f2) + -- -- Try some concurrent index drops -- *** a/src/test/regress/sql/create_index.sql --- b/src/test/regress/sql/create_index.sql *************** *** 721,730 **** BEGIN; CREATE INDEX std_index on concur_heap(f2); COMMIT; ! -- check to make sure that the failed indexes were cleaned up properly and the ! -- successful indexes are created properly. Notably that they do NOT have the ! -- "invalid" flag set. ! \d concur_heap -- --- 721,733 ---- CREATE INDEX std_index on concur_heap(f2); COMMIT; ! -- Failed builds are left invalid by VACUUM FULL, fixed by REINDEX ! VACUUM FULL concur_heap; ! REINDEX TABLE concur_heap; ! DELETE FROM concur_heap WHERE f1 = 'b'; ! VACUUM FULL concur_heap; ! \d concur_heap ! REINDEX TABLE concur_heap; \d concur_heap --