From 2cc8cde745140a17c35c17fe3ff10f0a4d5cd12a Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 14 Oct 2024 09:00:15 +0200 Subject: [PATCH 2/2] Fix unnecessary casts of copyObject() result The result is already of the correct type, so these casts don't do anything. --- src/backend/commands/trigger.c | 2 +- src/backend/nodes/nodeFuncs.c | 4 ++-- src/backend/rewrite/rewriteManip.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c index 3671e82535e..09356e46d16 100644 --- a/src/backend/commands/trigger.c +++ b/src/backend/commands/trigger.c @@ -1169,7 +1169,7 @@ CreateTriggerFiringOn(CreateTrigStmt *stmt, const char *queryString, * Initialize our fabricated parse node by copying the original * one, then resetting fields that we pass separately. */ - childStmt = (CreateTrigStmt *) copyObject(stmt); + childStmt = copyObject(stmt); childStmt->funcname = NIL; childStmt->whenClause = NULL; diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c index 0d00e029f32..f76072228c9 100644 --- a/src/backend/nodes/nodeFuncs.c +++ b/src/backend/nodes/nodeFuncs.c @@ -2996,7 +2996,7 @@ expression_tree_mutator_impl(Node *node, case T_SortGroupClause: case T_CTESearchClause: case T_MergeSupportFunc: - return (Node *) copyObject(node); + return copyObject(node); case T_WithCheckOption: { WithCheckOption *wco = (WithCheckOption *) node; @@ -3604,7 +3604,7 @@ expression_tree_mutator_impl(Node *node, break; case T_PartitionPruneStepCombine: /* no expression sub-nodes */ - return (Node *) copyObject(node); + return copyObject(node); case T_JoinExpr: { JoinExpr *join = (JoinExpr *) node; diff --git a/src/backend/rewrite/rewriteManip.c b/src/backend/rewrite/rewriteManip.c index b20625fbd2b..8f90afb3269 100644 --- a/src/backend/rewrite/rewriteManip.c +++ b/src/backend/rewrite/rewriteManip.c @@ -1715,7 +1715,7 @@ ReplaceVarsFromTargetList_callback(Var *var, break; case REPLACEVARS_CHANGE_VARNO: - var = (Var *) copyObject(var); + var = copyObject(var); var->varno = rcon->nomatch_varno; /* we leave the syntactic referent alone */ return (Node *) var; -- 2.47.0