From 8607281424d49727813ec902394fe4454ffa2755 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Wed, 28 Sep 2022 10:16:49 -0700 Subject: [PATCH v1 5/6] mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for msvc While mingw would otherwise fall back to __attribute__((visibility("default"))), that appears to only work as long as no symbols are declared with __declspec(dllexport). But we can end up with some, e.g. plpython's Py_Init. It's quite possible we should do the same for cygwin, but I don't have a test environment for that... Discussion: http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.de Discussion: http://postgr.es/m/20220928025242.ugf7t5ugxxgmkraa@awork3.anarazel.de --- src/include/port/win32.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/include/port/win32.h b/src/include/port/win32.h index 67755aadc40..d6c13d0bb8f 100644 --- a/src/include/port/win32.h +++ b/src/include/port/win32.h @@ -49,9 +49,11 @@ #endif /* - * Under MSVC, functions exported by a loadable module must be marked - * "dllexport". Other compilers don't need that. + * Functions exported by a loadable module must be marked "dllexport". + * + * While mingw would otherwise fall back to + * __attribute__((visibility("default"))), that appears to only work as long + * as no symbols are declared with __declspec(dllexport). But we can end up + * with some, e.g. plpython's Py_Init. */ -#ifdef _MSC_VER #define PGDLLEXPORT __declspec (dllexport) -#endif -- 2.37.3.542.gdd3f6c4cae