From 768f91199b5e197759b2ead6d838a72974dca6b6 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Thu, 5 Nov 2020 12:14:24 -0600 Subject: [PATCH 2/2] index_get_partition(): use lsyscache ?? The old code failed when !HeapTupleIsValid(), the new code will return false - is that ok ?? --- src/backend/catalog/partition.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c index 4dfac39adf..3d78bc0872 100644 --- a/src/backend/catalog/partition.c +++ b/src/backend/catalog/partition.c @@ -28,6 +28,7 @@ #include "partitioning/partbounds.h" #include "rewrite/rewriteManip.h" #include "utils/fmgroids.h" +#include "utils/lsyscache.h" #include "utils/partcache.h" #include "utils/rel.h" #include "utils/syscache.h" @@ -158,17 +159,8 @@ index_get_partition(Relation partition, Oid indexId) foreach(l, idxlist) { Oid partIdx = lfirst_oid(l); - HeapTuple tup; - Form_pg_class classForm; - bool ispartition; - - tup = SearchSysCache1(RELOID, ObjectIdGetDatum(partIdx)); - if (!HeapTupleIsValid(tup)) - elog(ERROR, "cache lookup failed for relation %u", partIdx); - classForm = (Form_pg_class) GETSTRUCT(tup); - ispartition = classForm->relispartition; - ReleaseSysCache(tup); - if (!ispartition) + + if (!get_rel_relispartition(partIdx)) continue; if (get_partition_parent(partIdx) == indexId) { -- 2.17.0