| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - allow to create partitioned tables |
| Date: | 2019-09-18 07:31:40 |
| Message-ID: | alpine.DEB.2.21.1909180921380.32172@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Amit,
> + fprintf(stderr, "invalid partition type,
> expecting \"range\" or \"hash\","
>
> How about "partitioning method" instead of "partition type"?
Indeed, this is a left over from a previous version.
> + fprintf(stderr, "--partition-method requires actual
> partitioning with --partitions\n");
>
> [...] "--partition-method requires --partitions to be greater than zero"
I think the first suggestion is clear enough. I've put a shorter variant
in the same spirit:
"--partitions-method requires greater than zero --partitions"
Attached v10 fixes both messages.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-init-partitioned-10.patch | text/x-diff | 12.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-09-18 07:40:19 | Re: Proposal: Add more compile-time asserts to expose inconsistencies. |
| Previous Message | Kyotaro Horiguchi | 2019-09-18 07:27:46 | Re: Efficient output for integer types |