From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: psql - add SHOW_ALL_RESULTS option |
Date: | 2019-04-26 16:38:47 |
Message-ID: | alpine.DEB.2.21.1904240654120.3407@lancre |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Aya-san,
Thanks for this review.
> There is space (+--' '). Please delete it. It is cause of regression test failed.
Indeed, unsure how I could do that. Fixed.
>> IMHO this new setting should be on by default: few people know about \; so
>> it would not change anything for most, and I do not see why those who use
>> it would not be interested by the results of all the queries they asked for.
> I agree with your opinion.
Ok. I did not yet change the default in the attached version, though.
> I test some query combination case. And I found when warning happen, the
> message is printed in head of results. I think it is not clear in which
> query the warning occurred.
Indeed.
> How about print warning message before the query that warning occurred?
Sure. It happened to be trickier than I thought to achieve this, because
there is a callback hook to send notifications.
This attached version does:
- ensure that warnings appear just before its
- add the entry in psql's help
- redefine the function boundary so that timing is cleaner
- include somehow improved tests
--
Fabien.
Attachment | Content-Type | Size |
---|---|---|
psql-show-all-results-2.patch | text/x-diff | 28.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-04-26 17:10:00 | Re: BUG #15781: subselect on foreign table (postgres_fdw) can crash (segfault) |
Previous Message | Alvaro Herrera | 2019-04-26 16:38:26 | Re: Segfault when restoring -Fd dump on current HEAD |