| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench - allow to store select results into variables |
| Date: | 2017-03-24 15:29:22 |
| Message-ID: | alpine.DEB.2.20.1703241616580.28545@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Rafia,
> if (my_command->argc > 2)
> + syntax_error(source, lineno, my_command->line, my_command->argv[0],
> + "at most on argument expected", NULL, -1);
>
> I suppose you mean 'one' argument here.
Indeed.
> Apart from that indentation is not correct as per pgindent, please check.
I guess that you are refering to switch/case indentation which my emacs
does not do as expected.
Please find attached a v8 which hopefully fixes these two issues.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-into-8.patch | text/x-diff | 16.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-24 15:29:32 | Re: [PATCH] Generic type subscripting |
| Previous Message | David Steele | 2017-03-24 15:26:35 | Re: cast result of copyNode() |