| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Speed up clean meson builds by ~25% |
| Date: | 2024-05-21 05:47:23 |
| Message-ID: | a38bffb8-fc15-48af-b5a7-e857200eb11c@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19.05.24 00:09, Andres Freund wrote:
> On 2024-05-18 00:35:08 +0200, Peter Eisentraut wrote:
>> I retested the patch from 2024-04-07 (I think that's the one that "fixed
>> that"? There are multiple "v1" patches in this thread.) using gcc-14 and
>> clang-18, with ccache disabled of course. The measured effects of the patch
>> are:
>>
>> gcc-14: 1% slower
>> clang-18: 3% faster
>>
>> So with that, it doesn't seem very interesting.
> I wonder whether the reason you're seing less benefit than Jelte is that - I'm
> guessing - you now used ninja 1.12 and Jelte something older. Ninja 1.12
> prioritizes building edges using a "critical path" heuristic, leading to
> scheduling nodes with more incoming dependencies, and deeper in the dependency
> graph earlier.
Yes! Very interesting!
With ninja 1.11 and gcc-14, I see the patch gives about a 17% speedup.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2024-05-21 05:48:27 | Re: broken tables on hot standby after migration on PostgreSQL 16 (3x times last month) |
| Previous Message | Michael Paquier | 2024-05-21 05:33:16 | Re: Cleaning up perl code |