From: | Damir <dam(dot)bel07(at)gmail(dot)com> |
---|---|
To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, andres(at)anarazel(dot)de, tgl(at)sss(dot)pgh(dot)pa(dot)us, daniel(at)yesql(dot)se, anisimow(dot)d(at)gmail(dot)com, HukuToc(at)gmail(dot)com, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru> |
Subject: | Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features) |
Date: | 2023-09-20 16:15:15 |
Message-ID: | a303c70a-ca58-fd8d-e5f5-00b941f24667@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Although v7 patch doesn't have commit messages on the patch, I think
> leave commit message is good for reviewers.
Sure, didn't notice it. Added the commit message to the updated patch.
> * Note: DON'T convert this error to "soft" style (errsave/ereturn). We
>> * want this data type to stay permanently in the hard-error world
>> so that
>> * it can be used for testing that such cases still work reasonably.
>
> From this point of view, I think this is a supposed way of using widget.
I agree, it's a good approach for checking datatype errors, because
that's what was intended.
> OTOH widget is declared in create_type.sql and I'm not sure it's ok to
> use it in another test copy2.sql.
I think that other regress tests with 'widget' type that will be created
in the future can be not only in the create_type.sql. So it's not a
problem that some type or function is taken from another regress test.
For example, the table 'onek' is used in many regress tests.
Regards,
Damir Belyalov
Postgres Professional
Attachment | Content-Type | Size |
---|---|---|
v7-0002-Add-new-COPY-option-IGNORE_DATATYPE_ERRORS.patch | text/x-patch | 12.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2023-09-20 16:54:24 | pg_upgrade --check fails to warn about abstime |
Previous Message | Lepikhov Andrei | 2023-09-20 15:17:46 | Re: disfavoring unparameterized nested loops |