| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Track the amount of time waiting due to cost_delay |
| Date: | 2024-10-11 17:12:34 |
| Message-ID: | ZwlcgptDl2Lg9S2a@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Sep 19, 2024 at 07:54:21AM +0000, Bertrand Drouvot wrote:
> Hi,
>
> On Wed, Sep 18, 2024 at 04:04:53PM -0500, Nathan Bossart wrote:
> > On Thu, Sep 05, 2024 at 04:59:54AM +0000, Bertrand Drouvot wrote:
> > > Please find attached v6, a mandatory rebase due to catversion bump conflict.
> > > I'm removing the catversion bump from the patch as it generates too frequent
> > > conflicts (just mention it needs to be done in the commit message).
> >
> > v6 looks generally reasonable to me.
>
> Thanks for looking at it!
>
> > I think the
> > nap_time_since_last_report variable needs to be marked static, though.
>
> Agree.
Please find attached v7 where nap_time_since_last_report is declared as static.
That's the only change as compared to v6.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Report-the-total-amount-of-time-that-vacuum-has-b.patch | text/x-diff | 8.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2024-10-11 17:39:37 | Re: Better error reporting from extension scripts (Was: Extend ALTER OPERATOR) |
| Previous Message | Alexander Korotkov | 2024-10-11 16:15:54 | Re: POC, WIP: OR-clause support for indexes |