Re: Switch PgStat_HashKey.objoid from Oid to uint64

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Switch PgStat_HashKey.objoid from Oid to uint64
Date: 2024-08-28 23:56:59
Message-ID: Zs-5S9az1Dk1XQEx@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 26, 2024 at 09:32:54AM +0300, Heikki Linnakangas wrote:
> Currently, we rely on the fact that all the xl_xact_* structs require
> sizeof(int) alignment. See comment above struct xl_xact_xinfo.

Thanks, I have missed this part. So that explains the alignment I'd
better use in the record.

> One idea is to store the uint64 as two uint32's.

Nice, we could just do that. This idea makes me feel much better than
sticking more aligment macros in the paths where the record is built.

Attached is an updated patch doing that. ubsan is silent with that.
--
Michael

Attachment Content-Type Size
v2-0001-Bump-PgStat_HashKey.objoid-to-be-8-bytes.patch text/x-diff 24.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-08-29 00:28:46 Re: allowing extensions to control planner behavior
Previous Message Peter Smith 2024-08-28 23:29:16 Re: Collect statistics about conflicts in logical replication