prevent 006_transfer_modes.pl from leaving files behind

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: andrew(at)dunslane(dot)net
Subject: prevent 006_transfer_modes.pl from leaving files behind
Date: 2025-04-07 21:45:52
Message-ID: Z_RHkG770w3SE0yU@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The other pg_upgrade tests chdir to tmp_check prior to running pg_upgrade
to avoid leaving behind delete_old_cluster.{sh,bat}. 006_transfer_modes.pl
should, too. However, this test is a little different because it loops
over all of the available transfer modes and runs pg_upgrade for each one
supported by the platform. From my testing and code analysis, it seems
sufficient to change the directory once at the beginning of the test, but
we could alternatively save the current directory and change back to it in
each iteration to be safe.

Thoughts?

--
nathan

Attachment Content-Type Size
v1-0001-Fix-the-006_transfer_modes.pl-test.patch text/plain 1.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-04-07 21:49:43 Re: [PoC] Federated Authn/z with OAUTHBEARER
Previous Message Sami Imseih 2025-04-07 21:39:46 Re: [PATCH] Re: Proposal to Enable/Disable Index using ALTER INDEX