| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
| Subject: | Re: warn if GUC set to an invalid shared library |
| Date: | 2024-01-07 13:27:00 |
| Message-ID: | ZZqmpB8a0CokcxwC@pryzbyj2023 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 22, 2022 at 03:26:47PM -0400, Tom Lane wrote:
> Hmph. I wonder if we shouldn't change that, because it's a lie.
> The value isn't actually coming from the config file, at least
> not yet.
On Thu, Jul 06, 2023 at 03:15:20PM -0500, Justin Pryzby wrote:
> On Sat, Oct 29, 2022 at 10:40 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > > > > On Fri, Sep 02, 2022 at 05:24:58PM -0500, Justin Pryzby wrote:
> > > > > > It caused no issue when I changed:
> > > > > >
> > > > > > /* Check that it's acceptable for the indicated parameter */
> > > > > > if (!parse_and_validate_value(record, name, value,
> > > > > > - PGC_S_FILE, ERROR,
> > > > > > + PGC_S_TEST, ERROR,
> > > > > > &newval, &newextra))
> > > > > >
> > > > > > I'm not sure where to go from here.
> > > > >
> > > > > I'm hoping for some guidance ; this simple change may be naive, but I'm not
> > > > > sure what a wider change would look like.
>
> I'm still hoping.
@cfbot: rebased
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-WIP-test-GUCs-from-ALTER-SYSTEM-as-PGC_S_TEST-not.patch | text/x-diff | 1.5 KB |
| v8-0002-warn-when-setting-GUC-to-a-nonextant-library.patch | text/x-diff | 9.7 KB |
| v8-0003-errcontext-if-server-fails-to-start-due-to-librar.patch | text/x-diff | 4.5 KB |
| v8-0004-show-the-GUC-source-in-errcontext.patch | text/x-diff | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2024-01-07 13:49:48 | Re: cannot abort transaction 2737414167, it was already committed |
| Previous Message | Tomas Vondra | 2024-01-07 10:51:56 | Re: Multidimensional Histograms |