Re: createuser --memeber and PG 16

On Mon, May 15, 2023 at 04:33:27PM +0900, Michael Paquier wrote:
> On Thu, May 11, 2023 at 09:34:42AM -0400, Bruce Momjian wrote:
> > On Thu, May 11, 2023 at 02:21:22PM +0200, Daniel Gustafsson wrote:
> >> IIRC there were a number of ideas presented in that thread but backwards
> >> compatibility with --role already "taken" made it complicated, so --role and
> >> --member were the least bad options.
> >>
> >>> At a minimum I would like to apply the attached doc patch to PG 16 to
> >>> improve awkward wording in CREATE ROLE and createuser.
> >>
> >> No objection.
>
> None from here as well.
>
> >> + role. (This in effect makes the new role a <quote>group</quote>.)
> >> While not introduced here, isn't the latter part interesting enough to warrant
> >> not being inside parenthesis?
> >
> > The concept of group itself is deprecated, which I think is why the
> > parenthesis are used.
>
> Not sure on this one. The original docs come from 58d214e, and this
> sentence was already in there.

True. I have removed the parenthesis in this updated patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Embrace your flaws. They make you human, rather than perfect,
which you will never be.