| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Normalization of utility queries in pg_stat_statements |
| Date: | 2023-03-03 00:37:27 |
| Message-ID: | ZAFBR1cwIq39ywX+@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 02, 2023 at 08:12:24AM +0100, Drouvot, Bertrand wrote:
> Applying 0001 produces:
>
> Applying: Split more regression tests of pg_stat_statements
> .git/rebase-apply/patch:1735: new blank line at EOF.
> +
> .git/rebase-apply/patch:2264: new blank line at EOF.
> +
> warning: 2 lines add whitespace errors.
Indeed, removed.
> What about removing those comments?
Removing these two as well.
> Except from the Nits above, 0001 LGTM.
Thanks for double-checking, applied 0001 to finish this part of the
work. I am attaching the remaining bits as of the attached, combined
into a single patch. I am going to look at it again at the beginning
of next week and potentially apply it so as the normalization reflects
to the reports of pg_stat_statements.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0003-Remove-normalization-of-A_Const-nodes.patch | text/x-diff | 10.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-03-03 00:37:32 | Re: Rework LogicalOutputPluginWriterUpdateProgress |
| Previous Message | Peter Smith | 2023-03-03 00:32:33 | Re: Allow logical replication to copy tables in binary format |