Re: convert libpgport's pqsignal() to a void function

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: convert libpgport's pqsignal() to a void function
Date: 2025-01-17 03:03:43
Message-ID: Z4nIj9vqcTRFClKs@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I've now committed all of this. I ended up finding a couple other frontend
programs that called pqsignal() with an invalid signal number on Windows,
so I fixed those as well. AFAICT the reason I didn't catch them in my
earlier testing is because they aren't tested! I'll keep an eye on the
buildfarm for any problems with the SIG_* redefinition removal, too.

Thanks for reviewing and for sharing lots of context about this stuff.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-01-17 03:16:15 Re: An improvement of ProcessTwoPhaseBuffer logic
Previous Message Noah Misch 2025-01-17 02:44:16 Re: An improvement of ProcessTwoPhaseBuffer logic