Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Akshat Jaimini <destrex271(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
Subject: Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts
Date: 2024-12-10 06:25:16
Message-ID: Z1fezFJJJwBxtnkD@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 14, 2024 at 06:57:21PM +0000, Akshat Jaimini wrote:
> Quick question, are there any more revisions left to be done on this
> patch from the previous feedback?

This patch is still listed in the CF app waiting on author with what
looks like Robert and Tom objecting to it, because it makes all
callers of CreateAndCopyRelationData() much more expensive in terms of
WAL generated when copying these files as the holes of the pages would
be included. This would also make the compression of the FPWs more
expensive.

One potential way to move forward would be to spread the knowledge of
page_std when logging a new page higher in the callers, then allow
dbcommands.c to be smarter about that?
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-12-10 06:27:29 Re: long-standing data loss bug in initial sync of logical replication
Previous Message Dilip Kumar 2024-12-10 06:18:44 Re: Skip collecting decoded changes of already-aborted transactions