| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Matthew Kim <matthewkmkim(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Remove dependence on integer wrapping |
| Date: | 2024-12-06 16:22:44 |
| Message-ID: | Z1Mk1FZ2beM9ee4q@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 05, 2024 at 09:58:29PM -0600, Nathan Bossart wrote:
> Thanks for reviewing. In v28, I fixed a silly mistake revealed by cfbot's
> Windows run. I also went ahead and tried to fix most of the issues
> reported in a nearby thread [0]. The only one I haven't tracked down yet
> is the "ISO week" one (case 7).
The overflow hazard for the ISO week case seems to be in isoweek2j(), which
would require quite a bit of restructuring to work with the soft-error
handling from its callers. I'm not feeling particularly inspired to do
that, so here's a v29 with a comment added above that function.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v29-0001-Fix-various-overflow-hazards-in-date-and-timesta.patch | text/plain | 12.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shayon Mukherjee | 2024-12-06 16:24:41 | Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch) |
| Previous Message | jian he | 2024-12-06 16:01:53 | Re: refactor AlterDomainAddConstraint (alter domain add constraint) |