| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Better error message when --single is not the first arg to postgres executable |
| Date: | 2024-12-03 19:57:15 |
| Message-ID: | Z09im9wfg83aHKuL@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks to Álvaro and Tom for reviewing.
On Tue, Dec 03, 2024 at 01:01:29PM -0500, Tom Lane wrote:
> +/* special must-be-first options for dispatching to various subprograms */
> +typedef enum Subprogram
> +{
> + SUBPROGRAM_CHECK,
> + ... etc
>
> "Subprogram" doesn't quite seem like the right name for this enum.
> These are not subprograms, they are options. I'm not feeling
> especially inventive today, so this might be a lousy suggestion,
> but how about
>
> typedef enum DispatchOption
> {
> DISPATCH_CHECK,
> ... etc
WFM. An alternative might be SubprogramOption, but I don't have any strong
opinions on the matter. I've switched it to DispatchOption in the attached
patch.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Provide-a-better-error-message-for-misplaced-disp.patch | text/plain | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-12-03 20:03:37 | Re: Doc: typo in config.sgml |
| Previous Message | Peter Eisentraut | 2024-12-03 19:35:10 | Re: CREATE SCHEMA ... CREATE DOMAIN support |