| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix 035_standby_logical_decoding.pl race conditions |
| Date: | 2025-04-08 06:42:53 |
| Message-ID: | Z/TFbWvjIGwsw5Hk@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Apr 08, 2025 at 03:27:41PM +0900, Michael Paquier wrote:
> On Tue, Apr 08, 2025 at 06:19:02AM +0000, Bertrand Drouvot wrote:
> > - A new injection_points_wakeup_detach() function that is holding the spinlock
> > during the whole duration to ensure that no process can wait in between the
> > wakeup and the detach.
>
> That would not a correct spinlock use. injection_points_detach() and
> injection_points_wakeup_internal() do much more actions than what we
> can internally do while holding a spinlock,
Fully agree. Will need to find another way to prevent a process to wait between the
wakeup and the detach. I'll open a dedicated thread.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2025-04-08 06:56:25 | RE: BUG #18815: Logical replication worker Segmentation fault |
| Previous Message | Andres Freund | 2025-04-08 06:40:52 | Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions |