| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Bernd Helmle <mailings(at)oopsware(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Subject: | Re: Allowing REINDEX to have an optional name |
| Date: | 2022-07-19 04:13:34 |
| Message-ID: | YtYvbtPCW2ztdUHy@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 18, 2022 at 09:26:53PM -0500, Justin Pryzby wrote:
> Sorry, I meant to send this earlier..
No problem.
> It looks like you named the table "toast_relfilenodes", but then also store
> to it data for non-toast tables.
How about naming that index_relfilenodes? One difference with what I
posted previously and 5fb5b6 is the addition of an extra regclass that
stores the parent table, for reference in the output.
> It's also a bit weird to call the column "relname" but use it to store the
> ::regclass. You later need to cast the column to text, so you may as well
> store it as text, either relname or oid::regclass.
I have used "indname" at the end.
> It seems like cluster.sql does this more succinctly.
Except that this does not include the relfilenodes from the toast
indexes, which is something I wanted to add a check for when it comes
to both user tables and catalogs.
> Why {4,5} ?
Looks like a brain fade from here, while looking the relation names
this generated. This could just match with an integer.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| reindexdb-tap.patch | text/x-diff | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2022-07-19 04:29:17 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | John Naylor | 2022-07-19 04:10:33 | Re: [PoC] Improve dead tuple storage for lazy vacuum |