| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Euler Taveira' <euler(at)eulerto(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | RE: speed up a logical replica setup |
| Date: | 2024-03-13 07:47:52 |
| Message-ID: | TYCPR01MB12077FD21BB186C5A685C0BF3F52A2@TYCPR01MB12077.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Euler,
Thanks for updating the patch! I have not reviewed yet, but cfbot did not
accept your patch [1]. It seems that you missed updating the windows part
in 0003 patch:
```
#if !defined(WIN32)
- sub_base_conninfo = psprintf("host=%s port=%u user=%s fallback_application_name=%s",
+ sub_base_conninfo = psprintf("host=%s port=%s user=%s fallback_application_name=%s",
opt.socket_dir, opt.sub_port, opt.sub_username, progname);
#else /* WIN32 */
sub_base_conninfo = psprintf("port=%u user=%s fallback_application_name=%s"
```
Since the change is quite trivial, I felt no need to update the versioning.
PSA the new set to keep the cfbot quiet. These could pass tests on my CI.
[1]: https://cirrus-ci.com/build/5253379782344704
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/global/
| Attachment | Content-Type | Size |
|---|---|---|
| v28-0001-pg_createsubscriber-creates-a-new-logical-replic.patch | application/octet-stream | 91.5 KB |
| v28-0002-Use-last-replication-slot-position-as-replicatio.patch | application/octet-stream | 7.5 KB |
| v28-0003-port-replace-int-with-string.patch | application/octet-stream | 3.7 KB |
| v28-0004-fix.patch | application/octet-stream | 994 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2024-03-13 07:58:52 | RE: Synchronizing slots from primary to standby |
| Previous Message | Jeff Davis | 2024-03-13 07:44:37 | Re: Built-in CTYPE provider |