From: | <Shinya11(dot)Kato(at)nttdata(dot)com> |
---|---|
To: | <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, <pgsql-hackers(at)postgresql(dot)org> |
Subject: | RE: Fix pg_checksums progress report |
Date: | 2021-04-02 07:30:32 |
Message-ID: | TYAPR01MB2896A762DDA55506F98F3F57C47A9@TYAPR01MB2896.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>-----Original Message-----
>From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
>Sent: Friday, April 2, 2021 2:39 PM
>To: Shinya11(dot)Kato(at)nttdata(dot)com; pgsql-hackers(at)postgresql(dot)org
>Subject: Re: Fix pg_checksums progress report
>
>
>
>On 2021/04/02 14:23, Shinya11(dot)Kato(at)nttdata(dot)com wrote:
>> Hi,
>>
>> I found a problem with the pg_checksums.c.
>>
>> The total_size is calculated by scanning the directory.
>> The current_size is calculated by scanning the files, but the current_size does
>not include the size of NewPages.
>>
>> This may cause pg_checksums progress report to not be 100%.
>> I have attached a patch that fixes this.
>
>Thanks for the report and patch!
>
>I could reproduce this issue and confirmed that the patch fixes it.
>
>Regarding the patch, I think that it's better to add the comment about why
>current_size needs to be counted including new pages.
Thanks for your review.
I added a comment to the patch, and attached the new patch.
Regards,
Shinya Kato
Attachment | Content-Type | Size |
---|---|---|
fix_pg_checksums_progress_report_v2.patch | application/octet-stream | 719 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2021-04-02 07:41:13 | Re: making update/delete of inheritance trees scale better |
Previous Message | Fujii Masao | 2021-04-02 07:28:45 | Re: Fix typo in verify_heapam.c |