From: | <Shinya11(dot)Kato(at)nttdata(dot)com> |
---|---|
To: | <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, <michael(at)paquier(dot)xyz> |
Cc: | <pgsql-hackers(at)postgresql(dot)org> |
Subject: | RE: Fix pg_checksums progress report |
Date: | 2021-04-02 09:19:32 |
Message-ID: | TYAPR01MB289689542AE87302F1EB9C4BC47A9@TYAPR01MB2896.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>-----Original Message-----
>From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
>Sent: Friday, April 2, 2021 6:03 PM
>To: Michael Paquier <michael(at)paquier(dot)xyz>; Shinya11(dot)Kato(at)nttdata(dot)com
>Cc: pgsql-hackers(at)postgresql(dot)org
>Subject: Re: Fix pg_checksums progress report
>
>
>
>On 2021/04/02 16:47, Michael Paquier wrote:
>> On Fri, Apr 02, 2021 at 07:30:32AM +0000, Shinya11(dot)Kato(at)nttdata(dot)com wrote:
>>> I added a comment to the patch, and attached the new patch.
>
>Thanks for updating the patch!
>
>+ /*
>+ * The current_size is calculated before checking if header is a
>+ * new page, because total_size includes the size of new
>pages.
>+ */
>+ current_size += r;
>
>I'd like to comment more. What about the following?
>
>---------------------------
>Since the file size is counted as total_size for progress status information, the
>sizes of all pages including new ones in the file should be counted as
>current_size. Otherwise the progress reporting calculated using those counters
>may not reach 100%.
>---------------------------
Thanks for your review!
I updated the patch, and attached it.
Regards,
Shinya Kato
Attachment | Content-Type | Size |
---|---|---|
fix_pg_checksums_progress_report_v3.patch | application/octet-stream | 860 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Laurenz Albe | 2021-04-02 09:37:39 | Re: badly calculated width of emoji in psql |
Previous Message | Peter Eisentraut | 2021-04-02 09:08:34 | Re: Add Nullif case for eval_const_expressions_mutator |