From: | "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi(dot)shinoda(at)hpe(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | "amitlangote09(at)gmail(dot)com" <amitlangote09(at)gmail(dot)com>, "masahiko(dot)sawada(at)2ndquadrant(dot)com" <masahiko(dot)sawada(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | RE: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |
Date: | 2020-03-03 05:37:57 |
Message-ID: | TU4PR8401MB11525B9DE88083DF353CE92FEEE40@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Thank you for developing good features.
The attached patch is a small fix to the committed documentation. This patch fixes the description literal for the backup_streamed column.
Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Fujii Masao [mailto:masao(dot)fujii(at)oss(dot)nttdata(dot)com]
Sent: Tuesday, March 3, 2020 12:09 PM
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: amitlangote09(at)gmail(dot)com; masahiko(dot)sawada(at)2ndquadrant(dot)com; pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side
On 2020/03/03 9:27, Kyotaro Horiguchi wrote:
> At Mon, 2 Mar 2020 17:29:30 +0900, Fujii Masao
> <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
>>> Attached is the updated version of the patch.
>>> The previous patch used only pgstat_progress_update_param() even
>>> when updating multiple values. Since those updates are not atomic,
>>> this can cause readers of the values to see the intermediate states.
>>> To avoid this issue, the latest patch uses
>>> pgstat_progress_update_multi_param(), instead.
>>
>> Attached the updated version of the patch.
>> Barring any objections, I plan to commit this patch.
>
> It is working as designed and the status names are fine to me.
Thanks for the review! I pushed the patch.
> The last one comment from me.
> The newly defined symbols have inconsistent indents.
Yes, I fixed that.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
Attachment | Content-Type | Size |
---|---|---|
monitoring_sgml.diff | application/octet-stream | 529 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2020-03-03 05:55:13 | Re: Parallel copy |
Previous Message | Michael Paquier | 2020-03-03 05:31:01 | Re: color by default |