From: | gkokolatos(at)pm(dot)me |
---|---|
To: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
Subject: | RE: Add LZ4 compression in pg_dump |
Date: | 2023-02-16 11:38:00 |
Message-ID: | SnTBJOQtJQf_mnXh6icTznqC05gnGqXKWDwjEA15uIx3zf0cJBwY1aK7ULztKoqlXrGM39lHtEpLGmS48A7585FXo1sO6W2YR5RtiDoWpDU=@pm.me |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
------- Original Message -------
On Wednesday, February 15th, 2023 at 2:51 PM, shiy(dot)fnst(at)fujitsu(dot)com <shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Hi,
>
> I am interested in this feature and tried the patch. While reading the comments,
> I noticed some minor things that could possibly be improved (in v27-0003 patch).
Thank you very much for the interest. Please find a rebased v28 attached. Due to
the rebase, 0001 of v27 is no longer relevant and has been removed. Your comments
are applied on v28-0002.
>
> 1.
> + /*
> + * Open a file for writing.
> + *
> + * 'mode' can be one of ''w', 'wb', 'a', and 'ab'. Requrires an already
> + * initialized CompressFileHandle.
> + */
> + int (*open_write_func) (const char *path, const char *mode,
> + CompressFileHandle CFH);
>
> There is a redundant single quote in front of 'w'.
Fixed.
>
> 2.
> /
> * Callback function for WriteDataToArchive. Writes one block of (compressed)
> * data to the archive.
> /
> /
> * Callback function for ReadDataFromArchive. To keep things simple, we
> * always read one compressed block at a time.
> */
>
> Should the function names in the comments be updated?
Agreed. Fixed.
>
> 3.
> + Assert(strcmp(mode, "r") == 0 || strcmp(mode, "rb") == 0);
>
> Could we use PG_BINARY_R instead of "r" and "rb" here?
We could and we should. Using PG_BINARY_R has the added benefit
of needing only one strcmp() call. Fixed.
Cheers,
//Georgios
>
> Regards,
> Shi Yu
Attachment | Content-Type | Size |
---|---|---|
v28-0003-Add-LZ4-compression-to-pg_dump.patch | text/x-patch | 29.7 KB |
v28-0002-Introduce-Compress-and-Compressor-API-in-pg_dump.patch | text/x-patch | 69.0 KB |
v28-0001-Prepare-pg_dump-internals-for-additional-compres.patch | text/x-patch | 14.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2023-02-16 11:46:50 | Re: Considering additional sort specialisation functions for PG16 |
Previous Message | Melih Mutlu | 2023-02-16 11:37:19 | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |