RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C

From: "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C
Date: 2024-11-07 21:42:58
Message-ID: PH8PR11MB82866E2249ABC8AA2E97497CFB5C2@PH8PR11MB8286.namprd11.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here is the updated patch with the #if defined(__has_attribute) && __has_attribute (target) guard.

> Oh, you are right, sorry.

No worries! 😊

> Is the idea that we will put both "choose" functions in one file and the actual
> CRC-32C code in another? I'm okay with that.

Yup, there can only be one choose function that has to pick between avx512, sse42 and scalar code.

Raghuveer

Attachment Content-Type Size
v2-0001-Use-__attribute__-target-sse4.2-for-SSE42-CRC32C.patch application/octet-stream 11.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexandra Wang 2024-11-07 21:57:58 Re: SQL:2023 JSON simplified accessor support
Previous Message Tom Lane 2024-11-07 21:38:30 Re: magical eref alias names