RE: Replica Identity check of partition table on subscriber

From: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Subject: RE: Replica Identity check of partition table on subscriber
Date: 2022-06-20 06:46:47
Message-ID: OSZPR01MB63101F1CDB8BA303649E5840FDB09@OSZPR01MB6310.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 20, 2022 1:33 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Jun 17, 2022 at 11:22 AM shiy(dot)fnst(at)fujitsu(dot)com
> <shiy(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > On Fri Jun 17, 2022 11:06 AM shiy(dot)fnst(at)fujitsu(dot)com <shiy(dot)fnst(at)fujitsu(dot)com>
> wrote:
> > >
> > > Attached the new version of patch set. I also moved the partitioned table
> > > check
> > > in logicalrep_rel_mark_updatable() to check_relation_updatable() as
> > > discussed
> > > [2].
> > >
> >
> > Attached back-branch patches of the first patch.
> >
>
> One minor comment:
> + /*
> + * If it is a partitioned table, we don't check it, we will check its
> + * partition later.
> + */
>
> Can we change the above comment to: "For partitioned tables, we only
> need to care if the target partition is updatable (aka has PK or RI
> defined for it)."?
>

Thanks for your comment. Modified in the attached patches.

Regards,
Shi yu

Attachment Content-Type Size
v11-0001-Fix-partition-table-s-RI-checking-on-the-subscri.patch application/octet-stream 9.5 KB
v11-pg13-0001-Fix-partition-table-s-RI-checking-on-the-subsc_patch application/octet-stream 9.7 KB
v11-pg14-0001-Fix-partition-table-s-RI-checking-on-the-subsc_patch application/octet-stream 9.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-06-20 07:13:43 Re: [BUG] Panic due to incorrect missingContrecPtr after promotion
Previous Message Masahiko Sawada 2022-06-20 06:35:00 Re: Add index scan progress to pg_stat_progress_vacuum