From: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
---|---|
To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | "sawada(dot)mshk(at)gmail(dot)com" <sawada(dot)mshk(at)gmail(dot)com>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "masao(dot)fujii(at)oss(dot)nttdata(dot)com" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "laurenz(dot)albe(at)cybertec(dot)at" <laurenz(dot)albe(at)cybertec(dot)at>, "ashutosh(dot)bapat(dot)oss(at)gmail(dot)com" <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: Disable WAL logging to speed up data loading |
Date: | 2021-01-15 14:18:26 |
Message-ID: | OSBPR01MB4888FB36DB58F6558C781E01EDA70@OSBPR01MB4888.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
Thank you everyone
On Thursday, January 14, 2021 9:27 AM Tsunakawa, Takayuki/綱川 貴之 <tsunakawa(dot)takay(at)fujitsu(dot)com> wrote:
> From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
> > > XLogSetRecordFlags(XLOG_MARK_UNIMPORTANT |
> > XLOG_MARK_ESSENTIAL);
> > > XLogRegisterData((char *) &dummy, sizeof(dummy));
> > >
> > > (Here's a word play - unimportant but essential, what's that?)
> >
> > Hmm. Food may not be important to someone but it is essential for
> > survival. I think this is somethig like that :p
>
> Ah, that's a good answer. I know a person around me who enjoys drinking
> alcohol but doesn't enjoy eating - he says he doesn't care about taste of food.
> So food is unimportant but nutrition is essential for him.
>
>
> > Unfortunately, I prefer the latter as it is simple because it is in a
> > hot path. As I think I mentioned upthread, I think the xlog stuff
> > should refrain from being conscious of things deeper than RMger-ID
> > level. One of other reasons is that generally the issuer site is the
> > authoritative about the importance and essentiality of a record being
> > issued. And I don't think it's very good to do the same thing in
> > different ways at the same time. Fortunately each type of the recrods
> > has only few issuer places.
>
> Agreed.
>
>
> > By the way, I noticed that pg_switch_wal() silently skips its task.
> > Desn't it need to give any sort of ERROR?
>
> Osumi-san, can you check this? (I thought we were aware of this according to
> Fujii-san's comment.)
I updated my patch to take in those feedbacks !
Have a look at the latest patch.
Best Regards,
Takamichi Osumi
Attachment | Content-Type | Size |
---|---|---|
disable_WAL_logging_v08.patch | application/octet-stream | 17.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | tsunakawa.takay@fujitsu.com | 2021-01-15 14:26:24 | RE: Determine parallel-safety of partition relations for Inserts |
Previous Message | tsunakawa.takay@fujitsu.com | 2021-01-15 14:04:53 | RE: Determine parallel-safety of partition relations for Inserts |