From: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Fabrice Chapuis <fabrice636861(at)gmail(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com> |
Subject: | RE: Logical replication timeout problem |
Date: | 2022-05-06 07:11:56 |
Message-ID: | OS3PR01MB62754AA446A2FB5B72816C529EC59@OS3PR01MB6275.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, May 6, 2022 at 9:54 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Wed, May 4, 2022 at 7:18 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Mon, May 2, 2022 at 8:07 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
> wrote:
> > >
> > > On Mon, May 2, 2022 at 11:32 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> > > >
> > > >
> > > > So, shall we go back to the previous approach of using a separate
> > > > function update_replication_progress?
> > >
> > > Ok, agreed.
> > >
> >
> > Attached, please find the updated patch accordingly. Currently, I have
> > prepared it for HEAD, if you don't see any problem with this, we can
> > prepare the back-branch patches based on this.
>
> Thank you for updating the patch. Looks good to me.
Thanks for your review.
Improve the back-branch patches according to the discussion.
Move the CHANGES_THRESHOLD logic from function OutputPluginUpdateProgress to
new funcion update_replication_progress.
In addition, improve all patches formatting with pgindent.
Attach the patches.
Regards,
Wang wei
Attachment | Content-Type | Size |
---|---|---|
HEAD_v21-0001-Fix-the-logical-replication-timeout-during-large.patch | application/octet-stream | 14.5 KB |
REL14_v4-0001-Fix-the-logical-replication-timeout-during-large-.patch | application/octet-stream | 13.4 KB |
REL13_v3-0001-Fix-the-logical-replication-timeout-during-large-.patch | application/octet-stream | 8.9 KB |
REL12_v3-0001-Fix-the-logical-replication-timeout-during-large-.patch | application/octet-stream | 8.9 KB |
REL11_v3-0001-Fix-the-logical-replication-timeout-during-large-.patch | application/octet-stream | 8.9 KB |
REL10_v3-0001-Fix-the-logical-replication-timeout-during-large-.patch | application/octet-stream | 8.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2022-05-06 08:04:55 | Re: strange slow query - lost lot of time somewhere |
Previous Message | Anton A. Melnikov | 2022-05-06 06:35:05 | Re: make MaxBackends available in _PG_init |