From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: [PATCH] Add tab-complete for backslash commands |
Date: | 2021-09-08 10:07:38 |
Message-ID: | OS0PR01MB611343BAA677D11B97463422FBD49@OS0PR01MB6113.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wednesday, September 8, 2021 5:05 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Sure, but he'd still get all the commands, just not all the possible
>spellings of each one. And a person who's not sure what's available
>is unlikely to be helped by an entry for "\c", because it's entirely
>not clear which command that's an abbreviation for.
>
>In any case, my main point is that the primary usage of tab-completion
>is as a typing aid, not documentation. I do not think we should make
>the behavior less useful for typing in order to be exhaustive on the
>documentation side.
You are right. I think I've got your point.
Here is the updated patch in which I added the multiple-character versions for backslash commands
and remove their corresponding single-character version.
Of course, for backslash commands with only single-character version, no change added.
BTW, I've done the existing tap-tests for tab-completion with this patch, all tests passed.
Regards,
Tang
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Replace-the-single-character-with-multiple-charac.patch | application/octet-stream | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Drouvot, Bertrand | 2021-09-08 10:08:43 | Re: Minimal logical decoding on standbys |
Previous Message | Juan José Santamaría Flecha | 2021-09-08 10:06:20 | Re: Atomic rename feature for Windows. |