From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com> |
Subject: | RE: Data is copied twice when specifying both child and parent table in publication |
Date: | 2021-12-02 08:54:18 |
Message-ID: | OS0PR01MB5716F7D44196B065449148B894699@OS0PR01MB5716.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thursday, December 2, 2021 12:50 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Thu, Dec 2, 2021 at 9:41 AM Greg Nancarrow <gregn4422(at)gmail(dot)com>
> wrote:
> >
> > On Thu, Dec 2, 2021 at 1:48 PM Greg Nancarrow <gregn4422(at)gmail(dot)com>
> wrote:
> > >
> > > If you updated my original description to say "(instead of just the
> > > individual partitions)", it would imply the same I think.
> > > But I don't mind if you want to explicitly state both cases to make it clear.
> > >
> >
> > For example, something like:
> >
> > For publications of partitioned tables with publish_via_partition_root
> > set to true, only the partitioned table (and not its partitions) is
> > included in the view, whereas if publish_via_partition_root is set to
> > false, only the individual partitions are included in the view.
> >
>
> Yeah, that sounds good to me.
It looks good to me as well.
Attach the patches for (HEAD~13) which merge the suggested doc change. I
prepared the code patch and test patch separately to make it easier for committer
to confirm.
Best regards,
Hou zj
Attachment | Content-Type | Size |
---|---|---|
HEAD-0001-Fix-double-publish-of-child-table-s-data.patch | application/octet-stream | 4.2 KB |
PG14-0001-Fix-double-publish-of-child-table-s-data.patch | application/octet-stream | 3.7 KB |
PG13-0001-Fix-double-publish-of-child-table-s-data.patch | application/octet-stream | 3.7 KB |
HEAD-0002-testcases.patch | application/octet-stream | 4.1 KB |
PG13-0002-testcases.patch | application/octet-stream | 3.3 KB |
PG14-0002-testcases.patch | application/octet-stream | 3.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-12-02 09:22:49 | pgcrypto: Remove explicit hex encoding/decoding from tests |
Previous Message | vignesh C | 2021-12-02 08:40:23 | Re: row filtering for logical replication |